-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel Exponential Histogram implementation #3022
Conversation
|
Because this uses Go-1.18 features, it makes sense to merge this to the |
This will fix #3027. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 My team and I are interested in this implementation and are actively following along. I'm looking at pulling this change in (via the launcher-go SDK) this week to test in our environment and will raise anything we see. Thank you!
…go into jmacd/backporthisto
…o jmacd/backporthisto
I believe this is blocked until #3081 merges, since it depends on Go-1.18+ and cannot build with 1.17. Otherwise, ready to review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
+ Coverage 76.2% 77.0% +0.7%
=======================================
Files 179 182 +3
Lines 11953 12376 +423
=======================================
+ Hits 9117 9531 +414
- Misses 2596 2601 +5
- Partials 240 244 +4
|
There are now slight upstream changes (e.g., an improved comment). https://github.com/lightstep/go-expohisto |
The implementation originally shown in #2393 used to finalize the OpenTelemetry specification and was split into parts to begin reviewing in pieces. The mapping functions were merged in #2502, and this is the corresponding data structure.
This data structure has been reviewed by Lightstep engineers and is running in production at Lightstep (i.e., for internal use). This code and the associated metrictransform logic (forked from upstream) is currently released at https://github.com/lightstep/otel-launcher-go/tree/v1.8.0/lightstep/sdk/metric/aggregator/histogram.
This code will be used to revive the OTel Collector statsd receiver: open-telemetry/opentelemetry-collector-contrib#6666.
Fixes #3027.
Part of #2966.
Related to #2501 and #2502.