Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.11.2/v0.34.0 #3512

Merged

Conversation

MadVikingGod
Copy link
Contributor

Added

Changed

Fixed

Removed

Deprecated

Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
…ental-metrics_v0.34.0' into mvg/release-2022-12-05

Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
Signed-off-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@2243431). Click here to learn what that means.
The diff coverage is 100.0%.

❗ Current head 7c1c4db differs from pull request most recent head 0928e40. Consider uploading reports for the commit 0928e40 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #3512   +/-   ##
======================================
  Coverage        ?   78.0%           
======================================
  Files           ?     165           
  Lines           ?   11809           
  Branches        ?       0           
======================================
  Hits            ?    9222           
  Misses          ?    2391           
  Partials        ?     196           
Impacted Files Coverage Δ
version.go 100.0% <100.0%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Dec 5, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@MadVikingGod MadVikingGod merged commit bc5cf7e into open-telemetry:main Dec 5, 2022
@MadVikingGod MadVikingGod deleted the mvg/release-2022-12-05 branch December 5, 2022 19:43
@yurishkuro
Copy link
Member

How do you rationalize this being a patch version 1.11.2, considering how many new features are released?

@christoffer-a63e
Copy link

christoffer-a63e commented Dec 6, 2022

Seems like a new release of https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc to match 1.11.2 and 0.34 must also be published? (latest is currently https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc@v0.33.0)

My go.mod (excerpt):

go 1.19

require (
        go.opentelemetry.io/otel v1.11.2
        go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.33.0
        go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.11.2
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.11.2
        go.opentelemetry.io/otel/metric v0.34.0
        go.opentelemetry.io/otel/sdk v1.11.2
        go.opentelemetry.io/otel/sdk/metric v0.34.0
)
$ go build .
>>

~/go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc@v0.33.0/client.go:48:20: undefined: otlpmetric.New
~/go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc@v0.33.0/client.go:66:68: undefined: otlpmetric.Client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants