Update OpenCensus metric bridge to use the metric.Producer interface #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
force-pushed
the
opencensus_producer
branch
from
4f90174
to
1aa24bb
Compare
dashpole
force-pushed
the
opencensus_producer
branch
from
1aa24bb
to
7e521eb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
=====================================
Coverage 78.0% 78.1%
=====================================
Files 164 164
Lines 11799 11815 +16
=====================================
+ Hits 9212 9232 +20
+ Misses 2391 2387 -4
Partials 196 196
|
MrAlias
approved these changes
Dec 15, 2022
dashpole
force-pushed
the
opencensus_producer
branch
2 times, most recently
from
29d8970
to
f4d3d26
Compare
hanyuancheung
approved these changes
Dec 19, 2022
dashpole
force-pushed
the
opencensus_producer
branch
from
da3df7c
to
b3eef31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3504
Fixes #2204
This adds NewMetricProducer, and deprecates NewMetricExporter.