Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept scope attributes during Tracer creation #3739

Merged
merged 8 commits into from
Feb 21, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 16, 2023

The OTel specification requires the instrumentation attributes are accepted by the API for the Tracer. This adds a TracerOption to satisfy that requirement.

Part of #3368

The OTel specification requires the instrumentation attributes are
accepted by the API for the Tracer. This adds a TracerOption to satisfy
that requirement.
@MrAlias MrAlias added pkg:API Related to an API package area:trace Part of OpenTelemetry tracing labels Feb 16, 2023
@MrAlias MrAlias added this to the Release v1.14.0 milestone Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #3739 (d3a9d9d) into main (1c5aed6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3739   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        166     166           
  Lines      12435   12442    +7     
=====================================
+ Hits       10155   10164    +9     
+ Misses      2065    2063    -2     
  Partials     215     215           
Impacted Files Coverage Δ
trace/config.go 68.1% <100.0%> (+3.9%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MadVikingGod MadVikingGod merged commit 99ec432 into open-telemetry:main Feb 21, 2023
@MrAlias MrAlias deleted the trace-scope-attr branch February 21, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants