chore: config selector #4001
Closed
chore: config selector #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
reviewed
May 1, 2023
| @@ -96,8 +93,11 @@ func (e *exporter) Shutdown(ctx context.Context) error { | |||
| // New return an Exporter that uses client to transmits the OTLP data it | |||
| // produces. The client is assumed to be fully started and able to communicate | |||
| // with its OTLP receiving endpoint. | |||
| func New(client Client) metric.Exporter { | |||
| return &exporter{client: client} | |||
| func New(client Client, cs ConfigSelector) metric.Exporter { | |||
There was a problem hiding this comment.
This change would make the otlpmetric package not backwards compatible. This shouldn't happen, but there is the case where someone upgrades grpc without upgrading the HTTP, it would pull this package up and break the not upgraded one. See #3846 for breaking this dependency.
Can we leave the arguments to New as is and use a different function to accomplish this?
That will mean that New() will need some way to get the ConfigSelector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3925