Replace Stream.AttributeFilter with AllowAttributeKeys
#4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure forward compatibility if a deny-list of attribute keys is ever added.
MrAlias
added
pkg:SDK
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dmathieu
reviewed
Jul 7, 2023
dashpole
approved these changes
Jul 7, 2023
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dmathieu
approved these changes
Jul 7, 2023
hanyuancheung
approved these changes
Jul 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 183 183
Lines 14207 14218 +11
=======================================
+ Hits 11877 11884 +7
- Misses 2104 2107 +3
- Partials 226 227 +1
|
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 14, 2023
…pen-telemetry#4288)" This reverts commit 1633c74.
MrAlias
added a commit
that referenced
this pull request
Aug 25, 2023
…w*Filter` functions (#4444) * Add allow/deny attr filters * Revert "Replace `Stream.AttributeFilter` with `AllowAttributeKeys` (#4288)" This reverts commit 1633c74. * Rename new attr filter funcs Do not include the term "Attribute" in a creation function of the "attribute" pkg. * Update the AttributeFilter field documentation * Add tests for filter creation funcs * Add change to changelog * Apply feedback * Use NewDenyKeysFilter for allow-all and deny-list filters * Remove links from field docs These links do not render. --------- Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4156
Note: the field name is
AllowAtttributeKeysinstead ofAttributeKeysto ensure forward compatibility in the case where the specification wants to add a deny-list for attribute keys (open-telemetry/opentelemetry-specification#3441).