Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log an error for an empty view criteria #4307

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Log an error for an empty view criteria #4307

merged 3 commits into from
Jul 12, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 11, 2023

Resolves #4149

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #4307 (02cc3ce) into main (fcc6709) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4307   +/-   ##
=====================================
  Coverage   83.6%   83.6%           
=====================================
  Files        183     183           
  Lines      14217   14221    +4     
=====================================
+ Hits       11889   11895    +6     
+ Misses      2102    2100    -2     
  Partials     226     226
Impacted Files Coverage Δ
sdk/metric/view.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jul 11, 2023
@MrAlias MrAlias marked this pull request as ready for review July 11, 2023 18:43
@MrAlias MrAlias changed the title Log an error for an empty view Log an error for an empty view criteria Jul 11, 2023
@MrAlias MrAlias merged commit 55fb2bb into open-telemetry:main Jul 12, 2023
21 of 22 checks passed
@MrAlias MrAlias deleted the err-empty-view branch July 12, 2023 22:10
@MrAlias MrAlias mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

Log an error for empty view criteria
4 participants
@MrAlias @dmathieu @dashpole @hanyuancheung