Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inst ID for agg cache key #4337

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Commits on Jul 18, 2023

  1. Use inst ID for agg cache key

    Resolve open-telemetry#4201
    
    The specification requires the duplicate instrument conflicts to be
    identified based on the instrument identifying fields:
    
    - name
    - instrument kind
    - unit
    - description
    - language-level features such as the number type (int64 and float64)
    
    Currently, the conflict detection and aggregation caching are done based
    on the stream IDs which include an aggregation name, monotonicity, and
    temporality instead of the instrument kind.
    
    This changes the conflict detection and aggregation caching to use the
    OpenTelemetry specified fields. This is effectively a no-op given there
    is a 1-to-1 mapping of aggregation-name/monotonicity/temporality to
    instrument kind (they are all resolved based on the instrument kind).
    
    Additionally, this adds a stringer representation of the
    `InstrumentKind`. This is needed for the logging of duplicate instrument
    conflicts.
    MrAlias committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    36ecb4b View commit details
    Browse the repository at this point in the history
  2. Add changes to changelog

    MrAlias committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ccecf4a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    30d544b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac55043 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    527ad39 View commit details
    Browse the repository at this point in the history