Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a view suggestion for duplicate instrument conflicts #4349

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 21, 2023

Resolve #4203

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #4349 (908df8f) into main (fd5284f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4349   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        184     184           
  Lines      14360   14383   +23     
=====================================
+ Hits       11984   12009   +25     
+ Misses      2149    2147    -2     
  Partials     227     227           
Impacted Files Coverage Δ
sdk/metric/pipeline.go 91.8% <100.0%> (+0.6%) ⬆️

... and 2 files with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit ab61991 into open-telemetry:main Jul 24, 2023
22 checks passed
@MrAlias MrAlias deleted the log-suggestion branch July 24, 2023 14:48
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Emit correct warning for duplicate instrument conflict
3 participants