Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the otlpmetric/internal package and sub-packages #4420

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 7, 2023

The plan is to remove this package after this has been released.

Part of #3846

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Aug 7, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 7, 2023
@pellared
Copy link
Member

pellared commented Aug 8, 2023

I think we should also deprecate exporters/otlp/otlpmetric package and module and add version.go to both otlpmetrichttp and otlpmetricgrpc modules. I would rather do it in a separate PR.

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 8, 2023

I think we should also deprecate exporters/otlp/otlpmetric package and module ...

Will this cause issues for users if there are sub-modules and sub-packages that are not deprecated?

and add version.go to both otlpmetrichttp and otlpmetricgrpc modules.

SGTM. We should also do the same for the otlptrace exporters.

I would rather do it in a separate PR.

👍

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4420 (fbf89ee) into main (6631519) will increase coverage by 0.0%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4420   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        229     229           
  Lines      18679   18679           
=====================================
+ Hits       15605   15607    +2     
+ Misses      2755    2753    -2     
  Partials     319     319           
Files Changed Coverage Δ
exporters/otlp/internal/config.go 100.0% <ø> (ø)
exporters/otlp/internal/retry/retry.go 98.3% <ø> (ø)
exporters/otlp/otlpmetric/internal/exporter.go 67.2% <ø> (ø)
...orters/otlp/otlpmetric/internal/oconf/envconfig.go 92.0% <ø> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <ø> (ø)
exporters/otlp/otlpmetric/internal/otest/client.go 96.8% <ø> (ø)
...orters/otlp/otlpmetric/internal/otest/collector.go 6.8% <ø> (ø)
exporters/otlp/otlptrace/exporter.go 66.6% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared
Copy link
Member

pellared commented Aug 8, 2023

Will this cause issues for users if there are sub-modules and sub-packages that are not deprecated?

AFAIK it should not cause any problem. Anyway verifying on a "test" repository would be safer than trusting me 😉

Still I think the PR can be merged as it is.

@MrAlias MrAlias merged commit e3ed198 into open-telemetry:main Aug 8, 2023
22 checks passed
@MrAlias MrAlias deleted the dep-otlpmetric-internal branch August 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants