Ignore +/- Inf and NaN for exponential histogram measurement #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
=======================================
- Coverage 78.9% 78.9% -0.1%
=======================================
Files 254 254
Lines 20646 20650 +4
=======================================
+ Hits 16301 16303 +2
- Misses 4000 4002 +2
Partials 345 345
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Aug 15, 2023
MadVikingGod
approved these changes
Aug 15, 2023
hanyuancheung
approved these changes
Aug 16, 2023
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 16, 2023
A guard was added in open-telemetry#4446 to prevent non-normal float64 from being recorded. This was added in the low-level `record` method meaning that the higher-level `measure` method will still keep a record of the invalid value measurement, just with a zero-value. This fixes that issue by moving the guard to the `measure` method.
MrAlias
added a commit
that referenced
this pull request
Aug 18, 2023
A guard was added in #4446 to prevent non-normal float64 from being recorded. This was added in the low-level `record` method meaning that the higher-level `measure` method will still keep a record of the invalid value measurement, just with a zero-value. This fixes that issue by moving the guard to the `measure` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4445
Similar to Java, follow the specification1 and do not record these values.
No changelog entry is made as the exponential histogram has not yet been released.
Footnotes
https://github.com/open-telemetry/opentelemetry-specification/blob/v1.24.0/specification/metrics/sdk.md#handle-all-normal-values ↩