Ignore value option for metricdatatest #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangelReale
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
MadVikingGod
approved these changes
Aug 22, 2023
hanyuancheung
approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #4447 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 220 220
Lines 17661 17670 +9
=====================================
+ Hits 14369 14378 +9
Misses 2992 2992
Partials 300 300
|
dmathieu
approved these changes
Aug 23, 2023
MrAlias
reviewed
Aug 23, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
reviewed
Sep 5, 2023
done. |
pellared
approved these changes
Sep 5, 2023
renovate bot
referenced
this pull request
in open-feature/flagd
Sep 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v0.40.0` -> `v0.41.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | | [go.opentelemetry.io/otel/exporters/prometheus](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v0.40.0` -> `v0.41.0` | | [go.opentelemetry.io/otel/metric](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | | [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | | [go.opentelemetry.io/otel/sdk/metric](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v0.40.0` -> `v0.41.0` | | [go.opentelemetry.io/otel/trace](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.18.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-go (go.opentelemetry.io/otel)</summary> ### [`v1.18.0`](https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.18.0): /v0.41.0/v0.0.6 [Compare Source](https://github.com/open-telemetry/opentelemetry-go/compare/v1.17.0...v1.18.0) This release drops the compatibility guarantee of [Go 1.19]. ##### Added - Add `WithProducer` option in `go.opentelemetry.op/otel/exporters/prometheus` to restore the ability to register producers on the prometheus exporter's manual reader. ([#​4473](https://github.com/open-telemetry/opentelemetry-go/issues/4473)) - Add `IgnoreValue` option in `go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest` to allow ignoring values when comparing metrics. ([#​4447](https://github.com/open-telemetry/opentelemetry-go/issues/4447)) ##### Deprecated - The `NewMetricExporter` in `go.opentelemetry.io/otel/bridge/opencensus` was deprecated in `v0.35.0` ([#​3541](https://github.com/open-telemetry/opentelemetry-go/issues/3541)). The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. ([#​4470](https://github.com/open-telemetry/opentelemetry-go/issues/4470)) ##### Removed - Removed the deprecated `go.opentelemetry.io/otel/exporters/jaeger` package. ([#​4467](https://github.com/open-telemetry/opentelemetry-go/issues/4467)) - Removed the deprecated `go.opentelemetry.io/otel/example/jaeger` package. ([#​4467](https://github.com/open-telemetry/opentelemetry-go/issues/4467)) - Removed the deprecated `go.opentelemetry.io/otel/sdk/metric/aggregation` package. ([#​4468](https://github.com/open-telemetry/opentelemetry-go/issues/4468)) - Removed the deprecated internal packages in `go.opentelemetry.io/otel/exporters/otlp` and its sub-packages. ([#​4469](https://github.com/open-telemetry/opentelemetry-go/issues/4469)) - Dropped guaranteed support for versions of Go less than 1.20. ([#​4481](https://github.com/open-telemetry/opentelemetry-go/issues/4481)) #### New Contributors - [@​pkbhowmick](https://github.com/pkbhowmick) made their first contribution in [https://github.com/open-telemetry/opentelemetry-go/pull/4462](https://github.com/open-telemetry/opentelemetry-go/pull/4462) - [@​RangelReale](https://github.com/RangelReale) made their first contribution in [https://github.com/open-telemetry/opentelemetry-go/pull/4447](https://github.com/open-telemetry/opentelemetry-go/pull/4447) **Full Changelog**: open-telemetry/opentelemetry-go@v1.17.0...v1.18.0 [Go 1.19]: https://go.dev/doc/go1.19 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in elastic/apm-queue
Oct 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v1.17.0` -> `v1.19.0` | | [go.opentelemetry.io/otel/sdk/metric](https://github.com/open-telemetry/opentelemetry-go) | require | minor | `v0.40.0` -> `v0.41.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-go (go.opentelemetry.io/otel/sdk)</summary> ### [`v1.19.0`](https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.19.0): /v0.42.0/v0.0.7 [Compare Source](https://github.com/open-telemetry/opentelemetry-go/compare/v1.18.0...v1.19.0) This release contains the first stable release of the OpenTelemetry Go [metric SDK]. Our project stability guarantees now apply to the `go.opentelemetry.io/otel/sdk/metric` package. See our [versioning policy](VERSIONING.md) for more information about these stability guarantees. ##### Added - Add the "Roll the dice" getting started application example in `go.opentelemetry.io/otel/example/dice`. ([#​4539](https://github.com/open-telemetry/opentelemetry-go/issues/4539)) - The `WithWriter` and `WithPrettyPrint` options to `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric` to set a custom `io.Writer`, and allow displaying the output in human-readable JSON. ([#​4507](https://github.com/open-telemetry/opentelemetry-go/issues/4507)) ##### Changed - Allow '/' characters in metric instrument names. ([#​4501](https://github.com/open-telemetry/opentelemetry-go/issues/4501)) - The exporter in `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric` does not prettify its output by default anymore. ([#​4507](https://github.com/open-telemetry/opentelemetry-go/issues/4507)) - Upgrade `gopkg.io/yaml` from `v2` to `v3` in `go.opentelemetry.io/otel/schema`. ([#​4535](https://github.com/open-telemetry/opentelemetry-go/issues/4535)) ##### Fixed - In `go.opentelemetry.op/otel/exporters/prometheus`, don't try to create the Prometheus metric on every `Collect` if we know the scope is invalid. ([#​4499](https://github.com/open-telemetry/opentelemetry-go/issues/4499)) ##### Removed - Remove `"go.opentelemetry.io/otel/bridge/opencensus".NewMetricExporter`, which is replaced by `NewMetricProducer`. ([#​4566](https://github.com/open-telemetry/opentelemetry-go/issues/4566)) **Full Changelog**: open-telemetry/opentelemetry-go@v1.18.0...v1.19.0 [metric SDK]: https://pkg.go.dev/go.opentelemetry.io/otel/sdk/metric ### [`v1.18.0`](https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.18.0): /v0.41.0/v0.0.6 [Compare Source](https://github.com/open-telemetry/opentelemetry-go/compare/v1.17.0...v1.18.0) This release drops the compatibility guarantee of [Go 1.19]. ##### Added - Add `WithProducer` option in `go.opentelemetry.op/otel/exporters/prometheus` to restore the ability to register producers on the prometheus exporter's manual reader. ([#​4473](https://github.com/open-telemetry/opentelemetry-go/issues/4473)) - Add `IgnoreValue` option in `go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest` to allow ignoring values when comparing metrics. ([#​4447](https://github.com/open-telemetry/opentelemetry-go/issues/4447)) ##### Deprecated - The `NewMetricExporter` in `go.opentelemetry.io/otel/bridge/opencensus` was deprecated in `v0.35.0` ([#​3541](https://github.com/open-telemetry/opentelemetry-go/issues/3541)). The deprecation notice format for the function has been corrected to trigger Go documentation and build tooling. ([#​4470](https://github.com/open-telemetry/opentelemetry-go/issues/4470)) ##### Removed - Removed the deprecated `go.opentelemetry.io/otel/exporters/jaeger` package. ([#​4467](https://github.com/open-telemetry/opentelemetry-go/issues/4467)) - Removed the deprecated `go.opentelemetry.io/otel/example/jaeger` package. ([#​4467](https://github.com/open-telemetry/opentelemetry-go/issues/4467)) - Removed the deprecated `go.opentelemetry.io/otel/sdk/metric/aggregation` package. ([#​4468](https://github.com/open-telemetry/opentelemetry-go/issues/4468)) - Removed the deprecated internal packages in `go.opentelemetry.io/otel/exporters/otlp` and its sub-packages. ([#​4469](https://github.com/open-telemetry/opentelemetry-go/issues/4469)) - Dropped guaranteed support for versions of Go less than 1.20. ([#​4481](https://github.com/open-telemetry/opentelemetry-go/issues/4481)) #### New Contributors - [@​pkbhowmick](https://github.com/pkbhowmick) made their first contribution in [https://github.com/open-telemetry/opentelemetry-go/pull/4462](https://github.com/open-telemetry/opentelemetry-go/pull/4462) - [@​RangelReale](https://github.com/RangelReale) made their first contribution in [https://github.com/open-telemetry/opentelemetry-go/pull/4447](https://github.com/open-telemetry/opentelemetry-go/pull/4447) **Full Changelog**: open-telemetry/opentelemetry-go@v1.17.0...v1.18.0 [Go 1.19]: https://go.dev/doc/go1.19 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elastic/apm-queue). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from this PR on the contrib repo.
Duration metrics are not predictable, so it was suggested to add an option in
metricdatatestto allow ignoring values when comparing metrics.