Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getBin and scaleChange methods of expoHistogramDataPoint #4451

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 16, 2023

Both functions receive parameters from an expoHistogramDataPoint and are only ever used by other methods of an expoHistogramDataPoint. Make the functions methods of expoHistogramDataPoint so the parameter arguments can be dropped and the functions are scoped to the type they are used for.

Both functions receive parameters from an expoHistogramDataPoint and are
only ever used by other methods of an expoHistogramDataPoint. Make the
functions methods of expoHistogramDataPoint so the parameter arguments
can be dropped and the functions are scoped to the type they are used
for.
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 16, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4451 (ab87e73) into main (9d9b71f) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4451   +/-   ##
=====================================
  Coverage   78.9%   78.9%           
=====================================
  Files        254     254           
  Lines      20642   20642           
=====================================
  Hits       16299   16299           
  Misses      3998    3998           
  Partials     345     345           
Files Changed Coverage Δ
...metric/internal/aggregate/exponential_histogram.go 96.1% <100.0%> (ø)

@MrAlias MrAlias merged commit 9b47674 into open-telemetry:main Aug 17, 2023
21 checks passed
@MrAlias MrAlias deleted the methods-instead-of-passed-params branch August 17, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants