Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a TB interface in metricdatatest #4483

Merged
merged 9 commits into from
Sep 11, 2023
Merged

Use a TB interface in metricdatatest #4483

merged 9 commits into from
Sep 11, 2023

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 7, 2023

Closes #4482.

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #4483 (01d46ea) into main (77d6237) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4483   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        220     220           
  Lines      17670   17670           
=====================================
+ Hits       14378   14380    +2     
+ Misses      2992    2990    -2     
  Partials     300     300
Files Changed Coverage
sdk/metric/metricdata/metricdatatest/assertion.go 100.0%

@dmathieu dmathieu changed the title Use testing.TB interface in metricdatatest Use a TB interface in metricdatatest Sep 7, 2023
pellared
pellared reviewed Sep 7, 2023
View reviewed changes
sdk/metric/metricdata/metricdatatest/assertion.go Outdated Show resolved Hide resolved
sdk/metric/metricdata/metricdatatest/assertion.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member

pellared commented Sep 8, 2023 •
edited
Loading

@dmathieu I added changes based on yesterday's SIG meeting conversation: 1712b9c

@pellared pellared mentioned this pull request Sep 11, 2023
Merged
@pellared pellared mentioned this pull request Sep 11, 2023
Closed
10 tasks
@MrAlias MrAlias merged commit ac4fca2 into open-telemetry:main Sep 11, 2023
21 checks passed
@dmathieu dmathieu deleted the tb-interface branch September 11, 2023 15:10
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@pellared pellared pellared approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

metricdatatest is not using TestingT interface
6 participants
@dmathieu @pellared @MadVikingGod @hanyuancheung @MrAlias @XSAM