-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Add design doc #4809
log: Add design doc #4809
Conversation
Co-authored-by: Benjamin Sanabria Carr <carrbens@gmail.com>
@jba Thanks a lot for your review 👍 Your (and others) feedback are welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this @pellared!
Plan is to merge this tomorrow unless there is more comments/feedback. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4809 +/- ##
=====================================
Coverage 82.6% 82.6%
=====================================
Files 232 232
Lines 18870 18870
=====================================
+ Hits 15603 15605 +2
+ Misses 2977 2975 -2
Partials 290 290 |
@peterbourgon @MrAlias @jack-berg @dashpole @carrbs @MadVikingGod @tigrannajaryan @jba thank you a lot for your help. |
First part of #3827
Fixes #4696
Prototype: #4725 (use it for reference when reviewing).