Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Flush method from Exemplar #4873

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 30, 2024

As pointed out in this comment, the Flush method is not needed in our implementation. We will delete the value holding the reservoir whenever we would have called Flush.

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jan 30, 2024
@MrAlias MrAlias added this to the v1.23.0 milestone Jan 30, 2024
@MrAlias MrAlias marked this pull request as ready for review January 30, 2024 20:39
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fecb92e) 82.6% compared to head (92c6ee9) 82.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4873     +/-   ##
=======================================
- Coverage   82.6%   82.6%   -0.1%     
=======================================
  Files        232     232             
  Lines      18872   18855     -17     
=======================================
- Hits       15600   15585     -15     
+ Misses      2982    2980      -2     
  Partials     290     290             
Files Coverage Δ
sdk/metric/internal/exemplar/drop.go 100.0% <ø> (ø)
sdk/metric/internal/exemplar/rand.go 97.6% <ø> (-0.1%) ⬇️
sdk/metric/internal/exemplar/storage.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit 242d23a into open-telemetry:main Jan 31, 2024
25 checks passed
@MrAlias MrAlias deleted the rm-exemplar-flush branch January 31, 2024 22:07
@MrAlias MrAlias mentioned this pull request Oct 1, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants