Add exemplar support to the prometheus exporter #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5111 +/- ##
=====================================
Coverage 83.7% 83.7%
=====================================
Files 252 252
Lines 16426 16450 +24
=====================================
+ Hits 13751 13772 +21
- Misses 2386 2388 +2
- Partials 289 290 +1
|
dashpole
added
enhancement
dashpole
force-pushed
the
prometheus_exemplars
branch
2 times, most recently
from
3c4924f
to
7d75f00
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
force-pushed
the
prometheus_exemplars
branch
from
7d75f00
to
912cbcd
Compare
MrAlias
approved these changes
Apr 1, 2024
dmathieu
reviewed
Apr 2, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dashpole
force-pushed
the
prometheus_exemplars
branch
from
a8f673e
to
525c53d
Compare
XSAM
approved these changes
Apr 3, 2024
pellared
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3163
Temporarily blocked on prometheus/client_golang#1479.The unit tests check for the exemplar in the protobuf output of the prometheus gatherer, rather than the final text format because exemplars are not supported in the prometheus text format (only openmetrics text format, or protobuf).