use NewRoot() standard code. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizthegrey
requested review from
iredelmeier,
jmacd,
krnowak,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
For now, the broken |
MrAlias
approved these changes
Mar 4, 2020
rghetia
approved these changes
Mar 4, 2020
MikeGoldsmith
pushed a commit
to MikeGoldsmith/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
othttp code was clashing with the code that automatically detects parent remote spans in the context; it needs
WithNewRoot()instead if public, and otherwise to do nothing to inherit as normal using the default propagation code.Fixes regression introduced by #451