Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base implementation of otlploghttp configuration #5167

Merged
merged 15 commits into from
Apr 11, 2024
Merged

Add base implementation of otlploghttp configuration #5167

merged 15 commits into from
Apr 11, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 5, 2024

Support direct option configuration and defaults.

Part of #5057

Follow up

  • Support environment variables
  • Validate user data

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels Apr 5, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.1%. Comparing base (1297d5f) to head (5f4836e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5167     +/-   ##
=======================================
+ Coverage   83.9%   84.1%   +0.1%     
=======================================
  Files        258     258             
  Lines      16647   16713     +66     
=======================================
+ Hits       13980   14065     +85     
+ Misses      2373    2354     -19     
  Partials     294     294
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/config.go 96.7% <96.1%> (+84.7%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review April 5, 2024 23:46
@MrAlias MrAlias mentioned this pull request Apr 8, 2024
Closed
15 tasks
@pellared pellared merged commit 7da00d9 into open-telemetry:main Apr 11, 2024
27 checks passed
@MrAlias MrAlias deleted the otlploghttp-base-conf branch April 11, 2024 19:04
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @dashpole @pellared