-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otlploghttp transform package #5191
Conversation
d30f9a5
to
654b3c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5191 +/- ##
=======================================
+ Coverage 84.1% 84.3% +0.1%
=======================================
Files 258 258
Lines 16713 16966 +253
=======================================
+ Hits 14067 14305 +238
- Misses 2352 2362 +10
- Partials 294 299 +5
|
654b3c4
to
647ee7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one comment that I find worth addressing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to move the implementation of transform to a shared place. But we can do that as parts of #5056
BTW, this PR seems to be assigned to a wrong project Go Auto Instrumentation: Beta (You might need to move it out of the project, I don't have the write permission of this project)
Part of #5057
This does not include testing for
Resource
orScope
values. See #5192.