sdk/log/logtest: Add RecordBuilder #5234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
=====================================
Coverage 84.6% 84.6%
=====================================
Files 258 259 +1
Lines 17349 17428 +79
=====================================
+ Hits 14678 14749 +71
- Misses 2360 2368 +8
Partials 311 311
|
pellared
changed the title
XSAM
reviewed
Apr 21, 2024
sdk/log/logtest/builder.go
Outdated
| } | ||
|
|
||
| // TODO: comment. | ||
| func (b Builder) Record() sdklog.Record { |
There was a problem hiding this comment.
Suggested change
| func (b Builder) Record() sdklog.Record { | |
| func (b Builder) Build() sdklog.Record { |
Builder builds. However, golang uses String for strings.Builder.
There was a problem hiding this comment.
That is why I decided to name it Record to follow the strings.Builder
pellared
changed the title
|
Making it an "actual PR" (not just a spike) based on initial feedback. |
pellared
changed the title
pellared
changed the title
|
Closing per #5258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5192.
My goal was to design the builder in a way to make it as much usable for exporter and processor testing as possible.
See test example for usage.
See also alternative design: #5258