Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the usage of go.opentelemetry.io/proto/slim #5253

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Apr 22, 2024

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 43.63636% with 217 lines in your changes are missing coverage. Please review.

Project coverage is 84.5%. Comparing base (b34cfc4) to head (5e7e772).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5253     +/-   ##
=======================================
- Coverage   85.5%   84.5%   -1.0%     
=======================================
  Files        258     258             
  Lines      17031   17349    +318     
=======================================
+ Hits       14570   14675    +105     
- Misses      2153    2363    +210     
- Partials     308     311      +3     
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/client.go 81.8% <ø> (ø)
...otlp/otlplog/otlploghttp/internal/transform/log.go 95.2% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 82.4% <ø> (ø)
...porters/otlp/otlpmetric/otlpmetrichttp/exporter.go 87.5% <ø> (ø)
...otlpmetric/otlpmetrichttp/internal/otest/client.go 97.7% <ø> (ø)
...ric/otlpmetrichttp/internal/transform/attribute.go 100.0% <ø> (ø)
...pmetric/otlpmetrichttp/internal/transform/error.go 100.0% <ø> (ø)
...ic/otlpmetrichttp/internal/transform/metricdata.go 100.0% <ø> (ø)
...pmetric/otlpmetricgrpc/internal/oconf/envconfig.go 92.9% <95.2%> (+0.9%) ⬆️
...pmetric/otlpmetrichttp/internal/oconf/envconfig.go 92.9% <93.7%> (+0.6%) ⬆️
... and 4 more

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 22, 2024
@XSAM
Copy link
Member Author

XSAM commented Apr 22, 2024

Skip the changelog, as the reverted commits have not been released.

@MrAlias MrAlias added this to the v1.26.0 milestone Apr 22, 2024
@pellared pellared merged commit bf37c5a into open-telemetry:main Apr 23, 2024
27 of 29 checks passed
@XSAM XSAM deleted the revert-usage-of-slim-otlp branch April 23, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to use both otelmetrichttp and otelmetricgrpc
4 participants