otlploggrpc: Remove unnecessary grpc client setup options #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
MrAlias,
Aneurysm9,
evantorrie,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
XSAM
changed the title
pellared
approved these changes
Apr 28, 2024
| // connection, just like grpc.WithInsecure() | ||
| // (https://pkg.go.dev/google.golang.org/grpc#WithInsecure) does. | ||
| // | ||
| // If the OTEL_EXPORTER_OTLP_ENDPOINT or OTEL_EXPORTER_OTLP_LOGS_ENDPOINT |
There was a problem hiding this comment.
We must remember to document all the env vars in Expoter type doc comments or package documentation.
This can be handled as a separate issue.
dmathieu
approved these changes
Apr 29, 2024
dashpole
reviewed
Apr 29, 2024
| // grpc.DialOptions are ignored. | ||
| // | ||
| // This option has no effect if WithGRPCConn is used. | ||
| func WithDialOption(_ ...grpc.DialOption) Option { |
There was a problem hiding this comment.
I think we should consider keeping DialOptions: #5248 (comment)
MrAlias
approved these changes
Apr 29, 2024
hanyuancheung
approved these changes
May 1, 2024
|
Closing this, as an existing use case mentioned in this #5248 (comment) won't be able to support if we merge this PR. However, We should consider this PR in v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #5056
Based on the recent discussion at the SIG meeting, we only provide the minimum option,
WithGRPCConn, for the grpc client to remove the burden of catching up on the latest grpc client option.