Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toolchain check #5983

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Add toolchain check #5983

merged 3 commits into from
Nov 18, 2024

Conversation

cheese-head
Copy link
Contributor

@cheese-head cheese-head commented Nov 16, 2024 •
edited by dmathieu
Loading

Fixes #5660

@MrAlias MrAlias mentioned this pull request Nov 16, 2024
Closed
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 16, 2024
@cheese-head cheese-head marked this pull request as ready for review November 16, 2024 00:30
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (74937a2) to head (c860c31).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5983   +/-   ##
=====================================
  Coverage   84.6%   84.6%           
=====================================
  Files        272     272           
  Lines      22897   22897           
=====================================
+ Hits       19389   19391    +2     
+ Misses      3164    3162    -2     
  Partials     344     344

see 1 file with indirect coverage changes

@dmathieu dmathieu changed the title add toolchain check Add toolchain check Nov 18, 2024
@pellared
Copy link
Member

@cheese-head, can you do the same in https://github.com/open-telemetry/opentelemetry-go-contrib?

@dmathieu dmathieu merged commit cc54b84 into open-telemetry:main Nov 18, 2024
32 checks passed
@MrAlias MrAlias mentioned this pull request Nov 18, 2024
Closed
@pellared pellared added this to the v1.33.0 milestone Nov 25, 2024
This was referenced Dec 17, 2024
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@dmathieu dmathieu dmathieu approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.

Do not use toolchain directive
4 participants
@cheese-head @pellared @dmathieu @MrAlias