Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated agentCollector and standaloneCollector configuration #199

Closed
TylerHelmuth opened this issue May 6, 2022 · 1 comment · Fixed by #216
Closed

Remove Deprecated agentCollector and standaloneCollector configuration #199

TylerHelmuth opened this issue May 6, 2022 · 1 comment · Fixed by #216
Assignees
Labels
chart:collector Issue related to opentelemetry-collector helm chart

Comments

@TylerHelmuth
Copy link
Member

The agentCollector and standaloneCollector configuration sections in values.yaml were deprecated as part of the 0.14.0 release of the charts (#159). These sections should be removed from values.yaml and all references to them in the templates should be cleaned up. NOTES.txt should be updated to fail any install that attempts to use agentCollector or standaloneCollector.

This work should not be completed until the collector is at version 0.52.0 (current version is 0.50.0) to give time for existing users of the charts to switch to using mode.

Open question: should mode be defaulted to daemonset? Once agentCollector is removed, the charts will not be able to be installed with the default values.yaml unless we set a default value for mode.

@TylerHelmuth TylerHelmuth added the chart:collector Issue related to opentelemetry-collector helm chart label May 6, 2022
@TylerHelmuth
Copy link
Member Author

0.52.0 has been released. I will get started on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant