Remove agentCollector and standaloneCollector #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitryax please take a look when you're free. |
dmitryax
reviewed
Jun 7, 2022
charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered/service.yaml
Outdated
Show resolved
Hide resolved
dmitryax
approved these changes
Jun 8, 2022
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
agentCollectorandstandaloneCollectorsections from values.yaml. Instead,modemust be used.An upgrade/install of the chart without
mode: daemonsetormode: deploymentwill fail. Since the current values.yaml uses.Values.agentCollector.enabled: true, users of the default values are usingagentCollectorsettings. In order to ensure that users who use the default values.yaml are not hit with any new surprise values (the defaultrequestsare different formode),modehas been left blank by default. As a result, the default values.yaml cannot be used to install the chart; all users must provide a values.yaml that setsmodefor the time being.Users who have switched to
modeas of 0.14.0 should not be impacted by this change.Fixes #199