Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex for extract_metadata_from_filepath added by #36 is too strict #42

Closed
techmunk opened this issue Apr 2, 2021 · 0 comments · Fixed by #89
Closed

Regex for extract_metadata_from_filepath added by #36 is too strict #42

techmunk opened this issue Apr 2, 2021 · 0 comments · Fixed by #89

Comments

@techmunk
Copy link

techmunk commented Apr 2, 2021

The regex is currently:
^.*\/(?P<namespace>[^_]+)_(?P<pod_name>[^_]+)_(?P<uid>[a-f0-9\-]{36})\/(?P<container_name>[^\._]+)\/(?P<run_id>\d+)\.log$

The uid check for 36 characters is too strict. I had to change the capture group to (?P<uid>[^\/]+), which also matches with what is currently in PR #38
@secustor secustor mentioned this issue Oct 19, 2021
Merged
matej-g pushed a commit to matej-g/opentelemetry-helm-charts that referenced this issue Nov 1, 2023
@povilasv
chore: update collector to 0.88.0 (open-telemetry#42)
99bc58a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(collector): upgrade to app version 0.37.1 secustor/opentelemetry-helm-charts
1 participant
@techmunk