[opentelemetry-collector] Add extension validation for health_check #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
ChrsMark
force-pushed
the
add_healthcheck_validation
branch
from
ffeaf58 to
d3a1da1
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_healthcheck_validation
branch
from
d3a1da1 to
a9a8ece
Compare
TylerHelmuth
approved these changes
Mar 12, 2024
dmitryax
approved these changes
Mar 15, 2024
12ushan
pushed a commit
to giffgaff/opentelemetry-helm-charts
that referenced
this pull request
Jul 22, 2024
…pen-telemetry#1070) Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validation check to ensue that
health_checkextension is always included in theextensionslist.This will ensure that users who manually define extensions will always add the
health_checkone as well as described at open-telemetry/opentelemetry-collector-contrib#29558 (comment).Without the
health_checkextension the collector would be failing.Fixes #974.