Simplify error scenario logic #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puckpuck
approved these changes
Jul 5, 2024
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
@beeme1mr please bump the chart version and run make generate-examples CHARTS=opentelemetry-demo
|
Hey @TylerHelmuth, the make command failed for some reason. I'll try and troubleshoot it when I have time. Is there any chance you could run it for me to get this PR unblocked? Thanks! |
|
@beeme1mr I did just that here beeme1mr#1 you can merge that in and your branch will have the update :) |
With make run
dosubot
bot
added
size:XL
|
Thanks @jaronoff97! |
TylerHelmuth
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to open-telemetry/opentelemetry-demo#1657