Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] fix span name cardinality #1258

Merged

Conversation

puckpuck
Copy link
Contributor

Fixes this issue in the demo repo.

This is a temporary fix, waiting for next.js to merge and release this PR.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team as a code owner July 16, 2024 03:29
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 18, 2024
@TylerHelmuth TylerHelmuth merged commit a7477af into open-telemetry:main Jul 18, 2024
3 checks passed
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@puckpuck puckpuck deleted the demo.fix-metric-cardinality branch July 23, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend spans are exploding cardinality by including request query params
4 participants