[operator] fix: move 'relabelings' and 'metricRelabelings' configs under endpoints in serviceMonitor spec

[rl0nergan]

Fixes indentation issues causing an invalid ServiceMonitor spec when using relabeling/metricRelabeling configs #1287

[jaronoff97]

suggestion: can we have all the blocks indentation match here?

[rl0nergan]

good call. just pushed those changes up

[TylerHelmuth]

I merged the operator-bump first, so needs a rebase

[rl0nergan]

using the following values for the serviceMonitor

  serviceMonitor:
    enabled: true
    # additional labels on the ServiceMonitor
    extraLabels: {}
    # add annotations on the ServiceMonitor
    annotations: {}
    metricsEndpoints:
      - port: metrics
    # Used to set relabeling and metricRelabeling configs on the ServiceMonitor
    # https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config
    relabelings:
      - action: replace
        replacement: my-cluster
        targetLabel: cluster
      - action: replace
        replacement: my-cluster2
        targetLabel: cluster2
    metricRelabelings:
      - action: keep
        regex: otelcol_process_memory_rss|target_info
        sourceLabels:
        - __name__

Templates out to this:

# Source: opentelemetry-operator/templates/servicemonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: otel-operator-opentelemetry-operator
  namespace: redpanda
  labels:
    helm.sh/chart: opentelemetry-operator-0.64.5
    app.kubernetes.io/name: opentelemetry-operator
    app.kubernetes.io/version: "0.103.0"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/instance: otel-operator
    
    app.kubernetes.io/component: controller-manager
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: opentelemetry-operator
      app.kubernetes.io/component: controller-manager
  endpoints:
  - port: metrics
    relabelings:
      - action: replace
        replacement: my-cluster
        targetLabel: cluster
      - action: replace
        replacement: my-cluster2
        targetLabel: cluster2
    metricRelabelings:
      - action: keep
        regex: otelcol_process_memory_rss|target_info
        sourceLabels:
        - __name__
  namespaceSelector:
    matchNames:
      - redpanda

Ignore the namespacing, that's just coming from the namespace set in my current kubeconfig.

[rl0nergan]

Updated PR with additional indentation:

# Source: opentelemetry-operator/templates/servicemonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: otel-operator-opentelemetry-operator
  namespace: redpanda
  labels:
    helm.sh/chart: opentelemetry-operator-0.65.1
    app.kubernetes.io/name: opentelemetry-operator
    app.kubernetes.io/version: "0.104.0"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/instance: otel-operator
    
    app.kubernetes.io/component: controller-manager
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: opentelemetry-operator
      app.kubernetes.io/component: controller-manager
  endpoints:
    - port: metrics
      relabelings:
        - action: replace
          replacement: my-cluster
          targetLabel: cluster
        - action: replace
          replacement: my-cluster2
          targetLabel: cluster2
      metricRelabelings:
        - action: keep
          regex: otelcol_process_memory_rss|target_info
          sourceLabels:
          - __name__
  namespaceSelector:
    matchNames:
      - redpanda