Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uninstall hook for the kube-stack chart #1305

Merged
merged 28 commits into from
Aug 20, 2024
Merged

Add uninstall hook for the kube-stack chart #1305

merged 28 commits into from
Aug 20, 2024

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Aug 13, 2024 •
edited
Loading

This adds an uninstall hook which makes sure that we get rid of the CRs before we uninstall the operator. Closes #1300

@jaronoff97 jaronoff97 requested a review from a team August 13, 2024 19:59
TylerHelmuth
TylerHelmuth reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont love that the hook's resources stick around after the helm chart is uninstalled.

charts/opentelemetry-kube-stack/templates/hooks.yaml Show resolved Hide resolved
charts/opentelemetry-kube-stack/values.yaml Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

@jaronoff97 can we reuse the prom live stack charts solution, whatever it is?

@jaronoff97 jaronoff97 mentioned this pull request Aug 19, 2024
Merged
@TylerHelmuth TylerHelmuth merged commit 96fc70a into open-telemetry:main Aug 20, 2024
3 checks passed