Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/opentelemetry-collector: recommended CPU limit pushes just over threshold #851

Merged
merged 2 commits into from
Aug 9, 2023
Merged

charts/opentelemetry-collector: recommended CPU limit pushes just over threshold #851

merged 2 commits into from
Aug 9, 2023

Commits on Aug 8, 2023

  1. charts/opentelemetry-collector: fix CPU limit 

    While "256m" is a valid setting, the intention was likely to allow
4 pods to be scheduled on a single CPU, which we will currently
overshoot by 24/1000, since there are only 1000 units in a CPU
fraction.

Adjust to "250m", which would allow exactly 4 pods to share a CPU.

See e.g. https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu
    @kevinburkesegment
    kevinburkesegment committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7e3f892 View commit details
    Browse the repository at this point in the history

  2. Update charts/opentelemetry-collector/values.yaml 

    Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
    @kevinburkesegment @TylerHelmuth
    kevinburkesegment and TylerHelmuth authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f1414bb View commit details
    Browse the repository at this point in the history