AWS ECS Detector: set cloud.{account.id,availability_zone,region,resource_id} #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
reviewed
Feb 2, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Feb 6, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java
Show resolved
Hide resolved
breedx-splk
reviewed
Feb 6, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Feb 6, 2024
breedx-splk
approved these changes
Feb 7, 2024
mmanciop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support in the AWS ECS detector to collect the
cloud.account.id,cloud.availability_zone,cloud.regionandcloud.resource_id(as discussed in open-telemetry/semantic-conventions#677) in line with what the AWS EC2 detector already supports.Existing Issue(s):
N/A
Testing:
Unit tests updated. Test data was already sufficient.
Documentation:
N/A
Outstanding items:
N/A