Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance for manual instrumentation usage #1250

Merged
merged 3 commits into from
May 1, 2024

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Apr 1, 2024

Description:

Adds section with recommended usage when performing manual instrumentation.

Testing:

  • ./gradlew assemble

Documentation:

  • Adds section to readme explaining the recommended way of using this artifact when doing manual instrumentation
  • Adds a link to reference example.

@psx95 psx95 requested a review from a team April 1, 2024 17:19
@github-actions github-actions bot requested a review from jsuereth April 1, 2024 17:19
gcp-resources/README.md Outdated Show resolved Hide resolved
gcp-resources/README.md Outdated Show resolved Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@psx95
Copy link
Contributor Author

psx95 commented Apr 29, 2024

@trask gentle ping - could we get this merged? I believe all pending comments have been resolved.

@trask trask merged commit 9964152 into open-telemetry:main May 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants