Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JMX metrics to support both a script and target systems #1339

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jaydeluca
Copy link
Member

Description:

The GroovyRunner supports loading multiple scripts, but currently only allows users to choose to run target systems or a custom script. This means that if someone wants to leverage both, they would need to run/manage multiple gatherer processes.

This change makes it so that users can specify target systems and custom groovy scripts in the same instance.

otel.jmx.service.url=service:jmx:rmi:///jndi/rmi://jetty:7203/jmxrmi
otel.jmx.target.system=jvm,hadoop
otel.jmx.groovy.script=/script.groovy

Existing Issue(s):

Resolves #937

Testing:

Test cases cover configuring target systems and scripts, as well as covering the case when otel.jmx.groovy.script might be a blank input string.

Documentation:

I updated readme, but feel free to point me to anywhere else that might need updating.

@jaydeluca jaydeluca force-pushed the jmx-script-and-targets branch from 837b65f to 367987e Compare June 7, 2024 20:52
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jaydeluca for picking this up!

@trask trask added this to the v1.37.0 milestone Jun 10, 2024
@trask trask merged commit 6f3cfa3 into open-telemetry:main Jun 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JMX Metrics Gatherer should be able to specify both jmx.target.system and jmx.groovy.script
6 participants