MeterProvider that delegates to Micrometer MeterRegistry #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaloFour
changed the title
|
Thanks @HaloFour! Are you able to be a component owner for this? If so, can you update https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/.github/component_owners.yml in this PR? I'd suggest renaming the top-level directory from |
|
Hey @trask! I wouldn't mind being a component owner for this at all. I've updated the component_owners file and renamed the module as suggested. |
...vider/src/main/java/io/opentelemetry/contrib/metrics/micrometer/MicrometerMeterProvider.java
Outdated
Show resolved
Hide resolved
...ava/io/opentelemetry/contrib/metrics/micrometer/internal/instruments/AbstractInstrument.java
Outdated
Show resolved
Hide resolved
| import io.opentelemetry.contrib.metrics.micrometer.internal.state.MeterSharedState; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| abstract class AbstractInstrumentBuilder<BuilderT extends AbstractInstrumentBuilder<BuilderT>> { |
There was a problem hiding this comment.
We're usually using UPPERCASE names for type parameters:
Suggested change
| abstract class AbstractInstrumentBuilder<BuilderT extends AbstractInstrumentBuilder<BuilderT>> { | |
| abstract class AbstractInstrumentBuilder<BUILDER extends AbstractInstrumentBuilder<BUILDER>> { |
There was a problem hiding this comment.
That's my preferred format as well, either spotless or checkstyle disagreed and required this format.
There was a problem hiding this comment.
Interesting... looks like we might have inconsistent errorprone configs between this repo and instrumentation.
There was a problem hiding this comment.
Here's the warning:
warning: [TypeParameterNaming] Type Parameter BUILDER must be a single letter with an optional numeric suffix, or an UpperCamelCase name followed by the letter 'T'.
abstract class AbstractInstrumentBuilder<BUILDER extends AbstractInstrumentBuilder<BUILDER>> {
^
(see https://google.github.io/styleguide/javaguide.html#s5.2.8-type-variable-names)
Did you mean 'abstract class AbstractInstrumentBuilder<BuilderT extends AbstractInstrumentBuilder<BuilderT>> {' or 'abstract class AbstractInstrumentBuilder<B extends AbstractInstrumentBuilder<B>> {'?
error: warnings found and -Werror specified
...er/src/main/java/io/opentelemetry/contrib/metrics/micrometer/ScheduledCallbackRegistrar.java
Outdated
Show resolved
Hide resolved
...o/opentelemetry/contrib/metrics/micrometer/internal/instruments/MicrometerDoubleCounter.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/contrib/metrics/micrometer/internal/instruments/MicrometerDoubleGauge.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/contrib/metrics/micrometer/internal/state/MeterSharedState.java
Outdated
Show resolved
Hide resolved
...egrationTest/java/io/opentelemetry/contrib/metrics/micrometer/PrometheusIntegrationTest.java
Outdated
Show resolved
Hide resolved
...rovider/src/test/java/io/opentelemetry/contrib/metrics/micrometer/TestCallbackRegistrar.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/contrib/metrics/micrometer/internal/PollingMeterCallbackRegistrarTest.java
Outdated
Show resolved
Hide resolved
HaloFour
force-pushed
the
micrometer-metrics
branch
from
ee2d9c7 to
f5fe2d4
Compare
...r-provider/src/main/java/io/opentelemetry/contrib/metrics/micrometer/internal/Constants.java
Outdated
Show resolved
Hide resolved
...va/io/opentelemetry/contrib/metrics/micrometer/internal/instruments/AtomicDoubleCounter.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/contrib/metrics/micrometer/internal/instruments/AbstractUpDownCounter.java
Outdated
Show resolved
Hide resolved
...vider/src/main/java/io/opentelemetry/contrib/metrics/micrometer/MicrometerMeterProvider.java
Outdated
Show resolved
Hide resolved
...entelemetry/contrib/metrics/micrometer/internal/instruments/MicrometerDoubleCounterTest.java
Outdated
Show resolved
Hide resolved
|
oh, that was unexpected, re-opening |
HaloFour
force-pushed
the
micrometer-metrics
branch
from
0b88d25 to
befdef4
Compare
mateuszrzeszutek
approved these changes
May 21, 2022
|
thx @HaloFour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Feature addition - Adds an implementation of OpenTelemetry Metrics
MeterProviderwhich wraps and delegates metrics to Micrometer 1.xMeterRegistry. This is to allow an existing project with an investment in Micrometer to iteratively migrate to OpenTelemetry without having to replace existing infrastructure code.Existing Issue(s):
N/A
Outstanding items: