Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try rate limited sampler for initialSampler of XRay remote samp… #68

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Aug 19, 2021

…ler.

To match behavior of X-Ray SDK and because testing apps locally can be harder if the backend is required just to see traces, 1 trace per second ensures that traces are created regardless of backend.

@anuraaga anuraaga requested a review from willarmiros as a code owner August 19, 2021 08:11
@anuraaga anuraaga requested a review from a team August 19, 2021 08:11
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anuraaga anuraaga merged commit 8d5794a into open-telemetry:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants