Skip to content

Commit

Permalink
Use configured NetPeerAttributes in OkHttp3 client tracer (#3063)
Browse files Browse the repository at this point in the history
This will make it notice the peer-service-mapping settings to set peer.service span attribute

I know this approach is deprecated but I hope to follow this up with another change to use the
new Instrumenter API.

#3009
  • Loading branch information
michaelbannister authored May 23, 2021
1 parent f11bd75 commit d1b9413
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
final class OkHttpClientTracer extends HttpClientTracer<Request, Request.Builder, Response> {

OkHttpClientTracer(OpenTelemetry openTelemetry) {
super(openTelemetry, new NetPeerAttributes());
super(openTelemetry, NetPeerAttributes.INSTANCE);
}

@Override
Expand Down

0 comments on commit d1b9413

Please sign in to comment.