-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Java agent to 2.x with upcoming ECS alignment changes #8280
Comments
I agree that a version bump sounds like a good idea. Is there a strategy for discontinuing support for the 1.x branch then? |
Should these changes be batched with other future semconv changes before bumping the major version? |
A couple of options:
|
If other semconv changes are ready then yes, but I wouldn't want to hold up adopting the new (hopefully finally stable) HTTP semconv changes. In general it's tricky for the Java agent since it bundles so many instrumentations together. Technically we don't guarantee telemetry stability across minor versions of the Java agent, but given the wide usage of HTTP instrumentation and the significant changes coming to HTTP semconv, it feels worth bumping the version in this case. |
One factor in deciding the approach will be the transition plan. For example if the transition plan doesn't allow for us to start emitting the new HTTP semconv by default for 6 months, then I'd probably want to add a flag to start emitting them sooner, in which case we'll have the flag support already and we can go with that option as part of sunsetting 1.x |
I updated this issue to include consideration of the |
Any other major breaking changes to consider? perhaps we need a |
In #8633 we propose overriding the autoconfigure behavior to revert otel.exporter.logs default from otlp to none. If we proceed, we should remove this override in the 2.x version. The affect in 2.x would be that log instrumentation is enabled by default, and otlp exporter of logs is enabled by default. |
Since were also working on stabilizing JVM runtime metrics, should we bundle these changes into a 2.x as well? |
Definitely 💯 |
I made a project board for tracking the work we have to do before releasing 2.0: https://github.com/orgs/open-telemetry/projects/54 Let's close this issue and use the project instead |
The upcoming HTTP semconv changes are going to be disruptive for lots of users, and I think it may justify bumping the Java agent from 1.x to 2.x to give users a really clear signal that they may need to take care when upgrading.
I'm not sure that the library instrumentations require bumping from 1.x to 2.x since they are all marked
-alpha
.EDIT: also consider including
http.(server|client).duration
metric change from milliseconds -> seconds in the 2.x bumpThe text was updated successfully, but these errors were encountered: