Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change http.server.duration and http.client.duration units to seconds #3390

Merged
merged 4 commits into from
Apr 15, 2023

Conversation

trask
Copy link
Member

@trask trask commented Apr 13, 2023

Fixes #3389

Changes

Changes http.server.duration and http.client.duration units to seconds.

@trask trask force-pushed the http-duration-to-seconds branch from cf66a5c to 1cbc90a Compare April 13, 2023 03:37
@trask trask marked this pull request as ready for review April 13, 2023 03:40
@trask trask requested review from a team April 13, 2023 03:40
@tigrannajaryan
Copy link
Member

Do we feel this is requires a similar advance notice treatment as other http convention changes or we think it is obscure enough and will have minimal impact? Do we know if this is widely implemented by our existing instrumentations?

@reyang
Copy link
Member

reyang commented Apr 13, 2023

Do we know if this is widely implemented by our existing instrumentations?

It is definitely not widely used, only few SDKs have released stable version of metrics, and just started HTTP metrics instrumentation experimental work.

@trask
Copy link
Member Author

trask commented Apr 13, 2023

the aberration here is Java agent instrumentation which has been emitting these metrics for ~1 year

we are already considering bumping the Java agent to 2.x with the upcoming ECS alignment changes and may choose to bundle this change into that update as well

@trask
Copy link
Member Author

trask commented Apr 14, 2023

Do we know if this is widely implemented by our existing instrumentations?

It is definitely not widely used, only few SDKs have released stable version of metrics, and just started HTTP metrics instrumentation experimental work.

we discussed in HTTP semconv stability WG, and our recommendation is that the transition plan for this change be left up to the language maintainers, with this general guidance:

  • if http metric instrumentation has been in wide use for a while (e.g. Java), it's probably good to bundle this change in with the upcoming HTTP semconv changes

cc @open-telemetry/opentelemetry-python-contrib-maintainers @open-telemetry/cpp-maintainers @open-telemetry/javascript-maintainers @open-telemetry/go-maintainers @open-telemetry/dotnet-maintainers @open-telemetry/dotnet-contrib-maintainers

@MrAlias
Copy link
Contributor

MrAlias commented Apr 14, 2023

Do we know if this is widely implemented by our existing instrumentations?

As a data point: It is implemented in the, non-stable, Go instrumentation otelhttp.

@trask trask deleted the http-duration-to-seconds branch October 14, 2024 21:04
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change http.server.duration and http.client.duration units to seconds
8 participants