-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change http.server.duration and http.client.duration units to seconds #3390
Conversation
cf66a5c
to
1cbc90a
Compare
Do we feel this is requires a similar advance notice treatment as other http convention changes or we think it is obscure enough and will have minimal impact? Do we know if this is widely implemented by our existing instrumentations? |
It is definitely not widely used, only few SDKs have released stable version of metrics, and just started HTTP metrics instrumentation experimental work. |
the aberration here is Java agent instrumentation which has been emitting these metrics for ~1 year we are already considering bumping the Java agent to 2.x with the upcoming ECS alignment changes and may choose to bundle this change into that update as well |
we discussed in HTTP semconv stability WG, and our recommendation is that the transition plan for this change be left up to the language maintainers, with this general guidance:
cc @open-telemetry/opentelemetry-python-contrib-maintainers @open-telemetry/cpp-maintainers @open-telemetry/javascript-maintainers @open-telemetry/go-maintainers @open-telemetry/dotnet-maintainers @open-telemetry/dotnet-contrib-maintainers |
As a data point: It is implemented in the, non-stable, Go instrumentation |
Fixes #3389
Changes
Changes
http.server.duration
andhttp.client.duration
units to seconds.