-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conver servlet 5 tests from groovy to java #12364
conver servlet 5 tests from groovy to java #12364
Conversation
@laurit do I need to create a jetty11 testing project to get rid of this?
|
We have two kinds of modules that are named |
@laurit can you check again? |
instrumentation/servlet/servlet-5.0/jetty11-testing/build.gradle.kts
Outdated
Show resolved
Hide resolved
instrumentation/servlet/servlet-5.0/jetty11-testing/build.gradle.kts
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/tomcat/TomcatServlet5Test.java
Outdated
Show resolved
Hide resolved
...lemetry/javaagent/instrumentation/servlet/v5_0/tomcat/mapping/TomcatServlet5MappingTest.java
Outdated
Show resolved
Hide resolved
8af9827
to
2f52981
Compare
Created by copying the servlet 3 tests and then applying the diffs from between the groovy servlet 3 and groovy servlet 5 tests