Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring starter: exclude spring routing data source from instrumentation #13054

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Spring starter: exclude spring routing data source from instrumentation #13054

merged 1 commit into from
Jan 16, 2025

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jan 16, 2025

Resolves #13051

@laurit laurit requested a review from a team as a code owner January 16, 2025 11:21
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Jan 16, 2025
@jeanbisutti
Copy link
Member

I have approved but I am not fully sure about the problem: #13051 (comment)

In addition, if AbstractRoutingDataSource is no longer wrapped, the underlying datasources managed by the routing datasource should probably be instrumented by being declared as Spring beans or with programmatic instrumentation (JdbcTelemetry) otherwise. We could document that. An alternative solution may be to have an AbstractRoutingDataSource instrumentation wrapping the underlying datasources if they are not wrapped.

@jeanbisutti
Copy link
Member

I have just seen that the problem was

DataSourcePostProcessor resulting in type exceptions in code.

@trask trask merged commit aaed8ac into open-telemetry:main Jan 16, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@steverao steverao steverao approved these changes

Assignees
No one assigned
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataSourcePostProcessor is incorrectly wrapping AbstractRoutingDataSource
6 participants
@laurit @jeanbisutti @zeitlinger @jaydeluca @steverao @trask