Make muzzle task depend on instrumentation project runtimeclasspath #1408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com
This is related to #1225. See the hacks what I did in regards to runtime classpath of the plugin. Maybe the plugin could expose a setting to configure javaagent-tooling and javaagent-bootstrap classpath (a similar what bytebuddy plugin does
opentelemetry-java-instrumentation/gradle/instrumentation.gradle
Line 36 in ee0e0a9
I am using muzzle plugin in my custom OTEL agent build. There are a couple of hacks that I had to make:
javaagent-tooling
andjavaagent-bootstrap
subprojects that pull in appropriate OTEL artifactsio.opentelemetry.instrumentation.
Make muzzle reference creation package(s) configurable #1395instrumentationMuzzle
)With all this I was able to run muzzle task and properly generate
instrumentationMuzzle
. However the build was passing only after./gradlew assemble
. Running./gradlew clean muzzle
was always failing. The following fixed the build on a clean project.