Apache camel enable sqs propagation #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
...t/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/SqsEndpointModel.java
Outdated
Show resolved
Hide resolved
jkwatson
reviewed
Jan 25, 2021
.../opentelemetry/javaagent/instrumentation/apachecamel/MessageAttributeNamesFactoryTest.groovy
Outdated
Show resolved
Hide resolved
|
Reworked to accommodate changes done for AWS SDK propagation + new tests :) |
|
Rebased to main (again). |
anuraaga
approved these changes
Feb 2, 2021
...mentation/apache-camel-2.20/javaagent-unittests/apache-camel-2.20-javaagent-unittests.gradle
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Feb 2, 2021
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
|
Trying to trigger |
mateuszrzeszutek
pushed a commit
to mateuszrzeszutek/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 5, 2021
* adding AWS SQS tests to Apache Camel instrumentation * code review changes Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * SQS context propagation for Apache Camel instrumentation * code review - removed not needed dep Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
mateuszrzeszutek
pushed a commit
that referenced
this pull request
Feb 5, 2021
* Apache camel enable sqs propagation (#2102) * adding AWS SQS tests to Apache Camel instrumentation * code review changes Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * SQS context propagation for Apache Camel instrumentation * code review - removed not needed dep Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * Bumped testcontainers version to make smoke tests pass Co-authored-by: Jakub Wach <jwach@splunk.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2079
Makes Camel automatically read message fields as set by current propagators, enabling context propagation.
Remark - in order to avoid muzzle failures for camel users without aws module, aws (SQS) specific code implemented as dynamic method handle invocations.