Expose correct Context.current() in reactive-netty callbacks #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
pavolloffay,
trask and
tylerbenson
as code owners
jkwatson
reviewed
Apr 22, 2021
...in/java/io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/DecoratorFunctions.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Apr 27, 2021
...-netty/reactor-netty-0.9/javaagent/src/test/groovy/AbstractReactorNettyHttpClientTest.groovy
Outdated
Show resolved
Hide resolved
...-netty/reactor-netty-1.0/javaagent/src/test/groovy/AbstractReactorNettyHttpClientTest.groovy
Show resolved
Hide resolved
iNikem
reviewed
Apr 28, 2021
...ntelemetry/javaagent/instrumentation/netty/v4_1/client/HttpClientResponseTracingHandler.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
reactor-netty-context
branch
from
1f267aa to
00080fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make sure to clean up channel attributes in netty 4.1 instrumentation.
doOnResolve,doAfterResolve,doOnResolveError,doOnConnectedanddoOnDisconnectedare not covered because they're called either too early or too late and getting any context from the connection in one of them is impossible.I think it closes #2776 - I've checked all HTTP clients that we instrument and that seemed "reactive" to me and none of them allow to set listeners like reactor-netty does (or none at all).