Moved jdbc-datasource instrumentation to Instrumenter API #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
99 tasks
trask
approved these changes
Jun 2, 2021
| public final class DataSourceInstrumenters { | ||
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.javaagent.jdbc"; | ||
|
|
||
| private static final Instrumenter<DataSource, Void> INSTRUMENTER; |
There was a problem hiding this comment.
would DataSource -> Method make sense?
There was a problem hiding this comment.
I tried that first - but I got different class names in tests (method.getDeclaringClass() vs dataSource.getClass()). I thought that it's probably a bit better to use the actual data source type in the attribute value, not the abstract/base class type.
anuraaga
approved these changes
Jun 3, 2021
robododge
pushed a commit
to robododge/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code.namespace,code.function)