Convert java-http-client to use Instrumenter API #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Aug 7, 2021
|
|
||
| /** Context propagation is implemented via {@link HttpHeadersInstrumentation}. */ | ||
| /** Context propagation is initiated in via {@link HttpHeadersInstrumentation}. */ |
There was a problem hiding this comment.
Suggested change
| /** Context propagation is initiated in via {@link HttpHeadersInstrumentation}. */ | |
| /** Context propagation is initiated in {@link HttpHeadersInstrumentation}. */ |
| .addAttributesExtractor(httpAttributesExtractor) | ||
| .addAttributesExtractor(netAttributesExtractor) | ||
| .addAttributesExtractor(PeerServiceAttributesExtractor.create(netAttributesExtractor)) | ||
| .addRequestMetrics(HttpClientMetrics.get()) |
99 tasks
mateuszrzeszutek
approved these changes
Aug 9, 2021
| } | ||
|
|
||
| @Override | ||
| protected @Nullable String flavor( |
There was a problem hiding this comment.
Nit
Suggested change
| protected @Nullable String flavor( | |
| protected String flavor( |
| } | ||
|
|
||
| @Override | ||
| protected @Nullable Integer statusCode(HttpRequest httpRequest, HttpResponse<?> httpResponse) { |
There was a problem hiding this comment.
Suggested change
| protected @Nullable Integer statusCode(HttpRequest httpRequest, HttpResponse<?> httpResponse) { | |
| protected Integer statusCode(HttpRequest httpRequest, HttpResponse<?> httpResponse) { |
| private static final Logger logger = LoggerFactory.getLogger(JdkHttpNetAttributesExtractor.class); | ||
|
|
||
| @Override | ||
| public @Nullable String transport(HttpRequest httpRequest) { |
There was a problem hiding this comment.
Suggested change
| public @Nullable String transport(HttpRequest httpRequest) { | |
| public String transport(HttpRequest httpRequest) { |
anuraaga
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Issue #2713.