Migrate Netty 4.x server instrumentations to Instrumenter API #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
99 tasks
trask
approved these changes
Oct 11, 2021
| .setSpanStatusExtractor(HttpSpanStatusExtractor.create(httpAttributesExtractor)) | ||
| .addAttributesExtractor(httpAttributesExtractor) | ||
| .addAttributesExtractor(new NettyNetServerAttributesExtractor()) | ||
| .addRequestMetrics(HttpServerMetrics.get()) |
...ntelemetry/javaagent/instrumentation/netty/v4_0/server/HttpServerResponseTracingHandler.java
Outdated
Show resolved
Hide resolved
testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
netty-4-instrumenter
branch
from
8b5e021 to
778a88c
Compare
iNikem
approved these changes
Oct 12, 2021
...ntelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java
Outdated
Show resolved
Hide resolved
...ntelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java
Show resolved
Hide resolved
...ntelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java
Show resolved
Hide resolved
…o/opentelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
mateuszrzeszutek
force-pushed
the
netty-4-instrumenter
branch
from
091097c to
53a1f8a
Compare
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…elemetry#4342) * Migrate Netty 4.x server instrumentations to Instrumenter API * fix vertx tests * codenarc * code review comments * fix broken assertion * Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2713
I decided to migrate netty 4.0 and 4.1 at the same time because they're almost the same and they're always used together in other server frameworks' testing code.