Convert RabbitMQ to Instrumenter #4463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
99 tasks
.../main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/TracedDelegatingConsumer.java
Show resolved
Hide resolved
| @@ -199,14 +206,17 @@ public static void extractAndStartSpan( | |||
| return; | |||
| } | |||
|
|
|||
| Context parentContext = Java8BytecodeBridge.currentContext(); | |||
| ReceiveRequest request = | |||
| ReceiveRequest.create(queue, startTime, response, channel.getConnection()); | |||
There was a problem hiding this comment.
Why is the response part of the request? Couldn't it be passed to the end() Instrumenter call?
There was a problem hiding this comment.
io.opentelemetry.javaagent.instrumentation.rabbitmq.RabbitReceiveAttributesExtractor#destination uses response to get required information
There was a problem hiding this comment.
That's strange that we're using exchange name for messaging.destination and queue name for span name - but I suppose that should be fixed in another PR; maybe once messaging conventions are stable.
...n/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitChannelInstrumentation.java
Outdated
Show resolved
Hide resolved
...gent/src/main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitSingletons.java
Show resolved
Hide resolved
.../main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitInstrumenterHelper.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Oct 26, 2021
trask
approved these changes
Oct 27, 2021
...gent/src/main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitSingletons.java
Show resolved
Hide resolved
|
|
||
| import java.time.Instant; | ||
|
|
||
| public final class Timer { |
There was a problem hiding this comment.
we have a few of these now, should we move to instrumentation-api (not in this PR)?
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Convert RabbitMQ to Instrumenter * Polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one strange instrumentation, which assigns attributes to span in arbitrary points of time from different methods...